Add support to gRPC #1088
Open
Add support to gRPC #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
reviewed
Jan 16, 2026
impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcExecutorBuilder.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Feb 2, 2026
impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcCallExecutor.java
Show resolved
Hide resolved
fjtirado
reviewed
Feb 2, 2026
impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcExecutor.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Feb 2, 2026
impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/WaitingStreamObserver.java
Outdated
Show resolved
Hide resolved
mcruzdev
commented
Feb 2, 2026
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryArgsExprTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
fjtirado
reviewed
Feb 10, 2026
Collaborator
There was a problem hiding this comment.
This one does not belong to this PR, isnt it?
fjtirado
reviewed
Feb 10, 2026
Collaborator
There was a problem hiding this comment.
same, I think this one is a leftover
Collaborator
Author
There was a problem hiding this comment.
Yes, it is a leftover
fjtirado
reviewed
Feb 10, 2026
fjtirado
reviewed
Feb 10, 2026
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
fjtirado
reviewed
Feb 10, 2026
impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcExecutor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
fjtirado
reviewed
Feb 12, 2026
| public CompletableFuture<WorkflowModel> apply( | ||
| WorkflowContext workflowContext, TaskContext taskContext, WorkflowModel input) { | ||
|
|
||
| Map<String, Object> arguments = this.arguments.apply(workflowContext, taskContext, input); |
Collaborator
There was a problem hiding this comment.
Probably this can directly passed to the method call (I like compact code and in this case the local variable hardly enhance readbility (on the contrary we have the same name for a local variable and a member)
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: fjtirado <ftirados@redhat.com>
Review suggestions
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request add gRPC support for:
It uses a library that downloads (cacheable) a
protocbinary based on the OS.Closes #1078